Update deps #24
Merged
Update deps #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJaredWilcurt
commented
Mar 14, 2024
| const express = require('express'); | ||
|
|
||
| const app = express(); | ||
| app.use(express.static('./dist-vue')); | ||
| app.listen(4185); | ||
| /* c8 ignore stop */ |
There was a problem hiding this comment.
Example server stub, ignoring for test coverage as it's the most basic express usage possible, so no need to deal with mocking this for tests, and it is simple specifically so people can easily replace it. Adding c8 ignores so they can more easily add coverage to the server.js if it has more custom logic.
TheJaredWilcurt
commented
Mar 14, 2024
| @@ -2,6 +2,8 @@ import vueSnapshotSerializer from './serializer.js'; | |||
|
|
|||
| expect.addSnapshotSerializer(vueSnapshotSerializer); | |||
|
|
|||
| global.document = global.window.document; | |||
| document.body.innerHTML = '<div id="app"></div>'; | |||
There was a problem hiding this comment.
Now that main.js is being tested we need to mock out #app so it can mount to something without throwing an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.